Work in Progress for Admin center and Config editor

[r-nikhil]

I was working on a separate branch in my fork. From now on I will commit to master so that you can review all the commits in one place i.e., here :)

[felipedaragon]

would not this make the admin center enabled by default and with a default password? https://github.com/sailorproject/sailor/pull/121/files#diff-aa9dd878052e45941a73be41206ba86aR17

if yes, for security reasons, I really would advise against having both, it enabled by default and a default password set

[r-nikhil]

This is not the final config file. It won't be enabled by default for sure. The password also has to be set manually for it's usage.

[felipedaragon]

@rnikhil275 nice! 🙃

[Etiene]

@felipedaragon Yes, I told him to open the PR already so it would be easier for me to review the code in progress :)

[Etiene]

Don't forget to update automatic tests on the dev app once you are done, so travis CI tests start passing! If you need help with that, let me know :)

tests are located at the test/dev-app, you can cd there and run sailor test

[Etiene]

I get stuck in a loop after I login in the admin center and try to access the autogen or the config edit when using Xavante

[r-nikhil]

It keeps getting redirected to the admin login page on Xavante probably because access.is_guest( ) always returns true in Xavante. This is the problem I was discussing with you.

[r-nikhil]

Regarding Indentations and moving functions outside sailor.lua, I will take care of them when I re-organize. Those functions may not even exist once the changes to Sailor are done

[r-nikhil]

Travis-CI fails now because the whole Autogen route/config thing has changed. Will update the tests. If I need help, will let you know :)

[r-nikhil]

With the last commit, the dashboard is now functional with autogen functions and the config editor. Please review it and let me know if I need to fix anything. I will start on the tests next

[r-nikhil]

Category.lua tests are failing which I don't understand why. I will remove the old autogen.lua test file now that it's inside the admin.lua test file.

Edit: I think I know why. os.remove() in admin tests gets executed but the subsequent test fails. This indirectly causes category controller tests also to fail.

[coveralls]

Coverage decreased (-0.2%) to 82.827% when pulling 25fce2de037f72f85dabfd738aed610c803058a8 on rnikhil275:master into a8e5b9288aff959f75bb83199ca6e8ac66900e98 on sailorproject:master.

[coveralls]

Coverage decreased (-0.2%) to 82.827% when pulling 25fce2de037f72f85dabfd738aed610c803058a8 on rnikhil275:master into a8e5b9288aff959f75bb83199ca6e8ac66900e98 on sailorproject:master.

[coveralls]

Coverage decreased (-0.2%) to 82.827% when pulling 25fce2de037f72f85dabfd738aed610c803058a8 on rnikhil275:master into a8e5b9288aff959f75bb83199ca6e8ac66900e98 on sailorproject:master.

[coveralls]

Coverage decreased (-0.2%) to 82.827% when pulling 25fce2de037f72f85dabfd738aed610c803058a8 on rnikhil275:master into a8e5b9288aff959f75bb83199ca6e8ac66900e98 on sailorproject:master.

[r-nikhil]

The coverage possibly decreased because the tests are incomplete. I will complete them but I having problem logging into admin (mostly because of access module). Also, the edit in admin.lua ("access.is_guest()" to "not access_is_guest()") should be reverted. It's a temp thing to figure out where the problem actually is.

[coveralls]

Coverage decreased (-0.2%) to 82.827% when pulling 0f8f830aa2e492df6fbfb84dcbe42415f357ae27 on rnikhil275:master into a8e5b9288aff959f75bb83199ca6e8ac66900e98 on sailorproject:master.

[coveralls]

Coverage decreased (-0.2%) to 82.827% when pulling 6ae526afaa416d0fec9d90107ff6f94ac518ca94 on rnikhil275:master into a8e5b9288aff959f75bb83199ca6e8ac66900e98 on sailorproject:master.

[coveralls]

Coverage decreased (-0.2%) to 82.827% when pulling 8b4f9fd01f46ac9691d5d0faf4683f348e1d451c on rnikhil275:master into a8e5b9288aff959f75bb83199ca6e8ac66900e98 on sailorproject:master.

[coveralls]

Coverage decreased (-0.2%) to 82.827% when pulling ac476ca1cbe46263b1064a0a4e97d64d9dc28357 on rnikhil275:master into a8e5b9288aff959f75bb83199ca6e8ac66900e98 on sailorproject:master.

[coveralls]

Coverage decreased (-0.2%) to 82.591% when pulling b6466fb063ce86d023a56597c75fd4913a1925dd on rnikhil275:master into 5dbcd7288517e2b95d98ae179f610a91197ff338 on sailorproject:master.

[coveralls]

Coverage decreased (-0.2%) to 82.591% when pulling b6466fb063ce86d023a56597c75fd4913a1925dd on rnikhil275:master into 5dbcd7288517e2b95d98ae179f610a91197ff338 on sailorproject:master.

[coveralls]

Coverage decreased (-0.1%) to 82.66% when pulling dda91d5b386db6844183dfc5917806717a44f312 on rnikhil275:master into a8e470b6c6a54064287cfc0e31623db253e9f85a on sailorproject:master.

[coveralls]

Coverage decreased (-0.1%) to 82.66% when pulling 37fbde57cc4ccb75c2c77b7abe5b004109a7815c on rnikhil275:master into a8e470b6c6a54064287cfc0e31623db253e9f85a on sailorproject:master.

[coveralls]

Coverage decreased (-0.1%) to 82.66% when pulling c1c8332d06f534c3a1ac7b911bb1dd8c4e4ad8c9 on rnikhil275:master into a8e470b6c6a54064287cfc0e31623db253e9f85a on sailorproject:master.

[coveralls]

Coverage decreased (-0.1%) to 82.517% when pulling e27741c11ffb665da6a6a6ac1391165ecffa6367 on rnikhil275:master into 9349bd5b1c66c36e1f93fcc7391edb1c14f37ab3 on sailorproject:master.

[coveralls]

Coverage decreased (-0.1%) to 82.517% when pulling e27741c11ffb665da6a6a6ac1391165ecffa6367 on rnikhil275:master into 9349bd5b1c66c36e1f93fcc7391edb1c14f37ab3 on sailorproject:master.

[coveralls]

Coverage decreased (-0.1%) to 82.517% when pulling e27741c11ffb665da6a6a6ac1391165ecffa6367 on rnikhil275:master into 9349bd5b1c66c36e1f93fcc7391edb1c14f37ab3 on sailorproject:master.

[Etiene]

closing due to lack of time to readdress this