Closed r-nikhil closed 5 years ago
would not this make the admin center enabled by default and with a default password? https://github.com/sailorproject/sailor/pull/121/files#diff-aa9dd878052e45941a73be41206ba86aR17
if yes, for security reasons, I really would advise against having both, it enabled by default and a default password set
This is not the final config file. It won't be enabled by default for sure. The password also has to be set manually for it's usage.
@rnikhil275 nice! 🙃
@felipedaragon Yes, I told him to open the PR already so it would be easier for me to review the code in progress :)
Don't forget to update automatic tests on the dev app once you are done, so travis CI tests start passing! If you need help with that, let me know :)
tests are located at the test/dev-app
, you can cd there and run sailor test
I get stuck in a loop after I login in the admin center and try to access the autogen or the config edit when using Xavante
It keeps getting redirected to the admin login page on Xavante probably because access.is_guest( ) always returns true in Xavante. This is the problem I was discussing with you.
Regarding Indentations and moving functions outside sailor.lua, I will take care of them when I re-organize. Those functions may not even exist once the changes to Sailor are done
Travis-CI fails now because the whole Autogen route/config thing has changed. Will update the tests. If I need help, will let you know :)
With the last commit, the dashboard is now functional with autogen functions and the config editor. Please review it and let me know if I need to fix anything. I will start on the tests next
Category.lua tests are failing which I don't understand why. I will remove the old autogen.lua test file now that it's inside the admin.lua test file.
Edit: I think I know why. os.remove() in admin tests gets executed but the subsequent test fails. This indirectly causes category controller tests also to fail.
The coverage possibly decreased because the tests are incomplete. I will complete them but I having problem logging into admin (mostly because of access module). Also, the edit in admin.lua ("access.is_guest()" to "not access_is_guest()") should be reverted. It's a temp thing to figure out where the problem actually is.
closing due to lack of time to readdress this
I was working on a separate branch in my fork. From now on I will commit to master so that you can review all the commits in one place i.e., here :)