search

sailorproject / sailor

A Lua MVC Web Framework.
MIT License
921 stars 125 forks source link

feat(cors): Add support for Cross Origin Requests #131

Closed soapdog closed 7 years ago

soapdog commented 7 years ago

Changed page module to add support for cross origin requests via page:enable_cors(). Added documentation and some tests as well.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-56.4%) to 26.4% when pulling 5741b06730112fb047f5ff909fe1f958f4ceb039 on amora-labs:enhancement-cors into ec8505e3b046e35bdcd77b0dc418def7b2c62e82 on sailorproject:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-56.4%) to 26.4% when pulling 5741b06730112fb047f5ff909fe1f958f4ceb039 on amora-labs:enhancement-cors into ec8505e3b046e35bdcd77b0dc418def7b2c62e82 on sailorproject:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-56.4%) to 26.4% when pulling 5741b06730112fb047f5ff909fe1f958f4ceb039 on amora-labs:enhancement-cors into ec8505e3b046e35bdcd77b0dc418def7b2c62e82 on sailorproject:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 81.903% when pulling 8d5d52fade8632eaa061ce0cd361ab03e5a04d95 on amora-labs:enhancement-cors into ec8505e3b046e35bdcd77b0dc418def7b2c62e82 on sailorproject:master.

soapdog commented 7 years ago

fixing these new errors...

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 81.903% when pulling 22b66a1f51e79c801b663d9158646aed70dd9ebf on amora-labs:enhancement-cors into ec8505e3b046e35bdcd77b0dc418def7b2c62e82 on sailorproject:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 81.903% when pulling 22b66a1f51e79c801b663d9158646aed70dd9ebf on amora-labs:enhancement-cors into ec8505e3b046e35bdcd77b0dc418def7b2c62e82 on sailorproject:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.9%) to 81.903% when pulling 22b66a1f51e79c801b663d9158646aed70dd9ebf on amora-labs:enhancement-cors into ec8505e3b046e35bdcd77b0dc418def7b2c62e82 on sailorproject:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 82.679% when pulling ecb2b90da1f3e134e56e1c13fb0eb6b87de63169 on amora-labs:enhancement-cors into ec8505e3b046e35bdcd77b0dc418def7b2c62e82 on sailorproject:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 82.679% when pulling ecb2b90da1f3e134e56e1c13fb0eb6b87de63169 on amora-labs:enhancement-cors into ec8505e3b046e35bdcd77b0dc418def7b2c62e82 on sailorproject:master.

soapdog commented 7 years ago

@Etiene sorry for the crazy pushing, I was having trouble running the tests locally. Now, it is working. I fixed the code and it now passes sailor test. Not sure about the coveralls thing. Can it be merged?

Etiene commented 7 years ago

awesome stuff!!! :D thanks for the great pr! yea, the coverall decreased because probably this new method needs automated tests, but Im not sure how that could be done. what do you think?

soapdog commented 7 years ago

I am new to Lua testing, so I have no idea how it could be done. I added two naive tests but I would like to see better ones.