Add version command on binary

sailorproject / sailor

A Lua MVC Web Framework.

MIT License

921 stars 125 forks source link

Add version command on binary #69

Open Etiene opened 8 years ago

Etiene commented 8 years ago

Update sailor binary (https://github.com/sailorproject/sailor/blob/master/sailor)
Add a --version, -v flag that will display Sailor's version
Add a start or server command that will run `start-server.lua"
Refactor code to use the lua_cliargs library (https://luarocks.org/modules/amireh/lua_cliargs)
Add lua_cliargs dependency to current rockspec (https://github.com/sailorproject/sailor/blob/master/rockspecs/sailor-current-1.rockspec)

xspager commented 8 years ago

Should adding more dependencies be avoided or can this https://github.com/amireh/lua_cliargs be used?

louis77 commented 8 years ago

https://github.com/amireh/lua_cliargs looks great. I guess the sailor CLI will grow over time so a library like this could be useful. I don't see any problem with dependencies to mature projects, are you?

Etiene commented 8 years ago

Yes, I agree using cliargs is a good call

xspager commented 8 years ago

Had a quick look at this but I found a big block, the lua_cliargs version for the latest version busted don't support commands.

UPDATE: Opened a Issue there: Olivine-Labs/busted#498

mpeterv commented 8 years ago

Shameless plug, there is another CLI parsing library that supports commands. Although waiting for release of busted-2.0.rc12 is probably better if you don't want to indirectly depend on two different libraries that do the same thing.

xspager commented 8 years ago

Nice! Will try it. :) Em 28/02/2016 10:03 AM, "Peter Melnichenko" notifications@github.com escreveu:

Shameless plug, there is another CLI parsing library that supports commands https://github.com/mpeterv/argparse. Although waiting for release of busted-2.0.rc12 is better if you don't to indirectly depend on two different libraries that do same thing.

— Reply to this email directly or view it on GitHub https://github.com/sailorproject/sailor/issues/69#issuecomment-189866110 .

xspager commented 8 years ago

Started a refactor using argparse as suggested by @mpeterv, check the branch https://github.com/sailorproject/sailor/compare/master...xspager:cli_refactor?expand=1

Still need verify if the behavior is similar to the old one and get the messages and more close to what it is right now.

@Etiene, can you change the points of this issue and the title to something more generic? :)

Feedback welcomed