search

sailpoint-oss / sailpoint-cli

The SailPoint Command Line Interface (CLI) makes it easy to interact with SailPoint's SaaS Platform in a programmatic way. Many functions that use to be accomplished through tools like Postman or from custom scripts can now be done directly on the command line with minimal setup.
https://developer.sailpoint.com/discuss
MIT License
25 stars 19 forks source link

Support for tenants other than identitynow.com #28

Closed fernando-delosrios-sp closed 1 year ago

fernando-delosrios-sp commented 1 year ago

Description

Current configuration takes for granted identitynow.com is the only base url IDN tenants have. These modifications remove that assumption and make client process tenant urls as {name}.{base} instead, modifying them for API endpoints as {name}.{"api"}.{base}.

How Has This Been Tested?

I've successfully registered an identitynow-demo.com tenant, created a connector and uploaded source code.

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

ghost commented 1 year ago

Hey @fernando-delosrios-sp!

I love the intent of this PR, and this is definitely something we needed to get done, since you went ahead and implemented this I want to get your thoughts on adding support for Vanity URLs in the URL schema.

I'm thinking in the OAuth flow, we add one additional prompt.

Something like: "If your IdentityNow tenant has a custom URL configured please provide it here (example of a custom tenant url):"

The documentation is here: https://community.sailpoint.com/t5/IdentityNow-Wiki/Creating-a-Vanity-URL/ta-p/75859

Please let me know your thoughts.

ghost commented 1 year ago

@fernando-delosrios-sp I wanted to follow up here, barring some other method of translating the data yet to be found, I think this is going to be one of the best methods to implement these changes, Thank you for the PR!