search

sailrish / shipit

shipit node module
MIT License
86 stars 65 forks source link

Timestamps are not correct, maybe depending on system timezone #27

Closed katylava closed 8 years ago

katylava commented 8 years ago

The delivered timestamp for 61299998245242452033 is 2016-04-12T15:23:00.000Z according to FedEx, but shipit converts it to 2016-04-12T10:23:00.000Z. My timezone is -5 hours, and it's 5 hours off, so could be something to do with that.

katylava commented 8 years ago

Or maybe depending on where the FedEx activity occurred... that would make more sense.

katylava commented 8 years ago

The tests are wrong here: https://github.com/sailrish/shipit/blob/master/test/fedex.coffee#L154 – the test is validating 2014-02-17T09:05:00.000Z, but the timestamp in the stub data is 2014-02-17T09:05:00-05:00.

sailrish commented 8 years ago

Fixed in #29.