search

sailrish / shipit

shipit node module
MIT License
86 stars 65 forks source link

Fixed issue with Moment.js Date formatting #40

Open jimallen opened 5 years ago

jimallen commented 5 years ago

The DHL test seem broken, I didn't touch it :)

sailrish commented 5 years ago

Hi @jimallen thanks for the PR. Just curious, how is this:

d = moment( inputText )

different from:

d = moment( new date( inputText ) )

I do realize I have a deprecation warning related to moment.js, that I still have to fix:

Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versi
ons. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
sailrish commented 5 years ago

Also, can you please paste the DHL test failure you're seeing? I don't see one locally, but that may be because of timezone related issues.

jasonharrison commented 5 years ago

@sailrish The moment.js depreciation warning is still present-- does this PR have any issues that need to be addressed?