sailro / EscapeFromTarkov-Trainer

Escape from Tarkov (EFT) Trainer - Internal
MIT License
612 stars 138 forks source link

Item ESP not working correctly #85

Closed Timoros98 closed 3 years ago

Timoros98 commented 3 years ago

Am using SPT-AKI 2.0.1 version

  1. The "List" command only returns EUR,USD,RUB
  2. The tracking is working only for loose items on the ground and not in containers!

The only tracking items in containers are the EUR,USD,RUB

Attaching images with the issues

2021-10-07 18-27 _58 4, 1 5, 20 0_0 0, -0 6, 0 0, 0 8 (2)

2021-10-07 18-27 _58 4, 1 5, 20 0_0 0, -0 6, 0 0, 0 8 (0)!

sailro commented 3 years ago

I'm still on sptarkov 2.0.0 so I have to upgrade first.

cc https://github.com/sailro/EscapeFromTarkov-Trainer/issues/73

Timoros98 commented 3 years ago

Ok so I will try 2.0.0 for now since is the same version of tarkov! When do you planning to upgrade to 2.0.1?

sailro commented 3 years ago

In a couple of hours. I'm going to double check. Could you share the following files ?:

Timoros98 commented 3 years ago

Ok i got it working on 2.0.1, it was the Allinone mod i was using, I suspect there is something with stamina in that mod but am not sure! i will test now and tell you So everything good in your end, but i want to use the mod with the trainer maybe try and find a solution as many player use it

2021-10-07 19-36 _45 9, 1 5, -40 7_0 0, -0 2, 0 0, 1 0 (0)

2021-10-07 19-36 _65 4, -1 2, -34 1_0 1, 0 0, 0 0, 1 0 (0)

sailro commented 3 years ago

Ah great.

@ShadoweCZ are you using extra mods like this?

Timoros98 commented 3 years ago

I disabled stamina from the other mod but still not working i will try disable one by one untill i have nothing changed from the other mod and if that's not working then the mod itself has something to do with it

Timoros98 commented 3 years ago

Good news @sailro I found the conflict

It seems that if you use AllInOne mod and change the weight of items to 0 then your trainer is not recognizing the item. So now is working properly

sailro commented 3 years ago

Good catch.

https://github.com/sailro/EscapeFromTarkov-Trainer/blob/master/Extensions/ItemExtension.cs#L23

Yes we are filtering all items without weight. And we made an exception for EUR,USD,RUB. That's why you were able to see them.

Timoros98 commented 3 years ago

Nice one! So for future people having the same problem the workaround is simply put something like "0.00001" for the weight and is now working!

So @sailro thanks for the help! I think keep the code this way because of the pockets and default inventory unless you have a solution to that! but if the workaround is working then don't get yourself into any trouble 😃

ShadoweCZ commented 3 years ago

Ah great.

@ShadoweCZ are you using extra mods like this?

yes, and i also had the weight set to 0 so i will change and try image

so my problem https://github.com/sailro/EscapeFromTarkov-Trainer/issues/73 of not seeing items was caused because they had no weight ?

Timoros98 commented 3 years ago

Ah great.

@ShadoweCZ are you using extra mods like this?

yes, and i also had the weight set to 0 so i will change and try image

so my problem https://github.com/sailro/EscapeFromTarkov-Trainer/issues/73 of not seeing items was caused because they had no weight ?

There is a very high possibilty that this is your problem too try removing the mod that make the items weightless and try again!

Mine was All In One mod and i can see from your screenshot that you have it enabled, check the config of that mod. The weight is at the top of that config file try make it something like "0.00001".

The config is located in the mods folder its easy to find, if you can't find it just tell me and i can help you!

ShadoweCZ commented 3 years ago

ye i did non zero zero weight xD and it works now image

so im closing https://github.com/sailro/EscapeFromTarkov-Trainer/issues/73 cause the problem isnt caused by updates

Timoros98 commented 3 years ago

ye i did non zero zero weight xD and it works now image

so im closing https://github.com/sailro/EscapeFromTarkov-Trainer/issues/73 cause the problem isnt caused by updates

Glad to hear that man!! Enjoy the trainer 😉👍

sailro commented 3 years ago

Ok great. Perhaps I have to change my strategy on my side as well to prevent that