search

sailscastshq / boring-stack

Ship JavaScript products with battle-tested technologies in days not weeks.
https://docs.sailscasts.com/boring-stack/getting-started
MIT License
427 stars 18 forks source link

Chore: Remove duplicate text on README #25

Closed d-a-ve closed 1 year ago

d-a-ve commented 1 year ago

Closes #23, #24

DominusKelvin commented 1 year ago

Hey @d-a-ve great job on this PR. Your PR does two things instead of one like the title of your PR said. Can you make this one PR fix the duplicate and then submit another one for adding the "Creating issues" section to the contributing guide?

d-a-ve commented 1 year ago

Thank you reviewing @DominusKelvin. It was a mistake on my part and I will make another PR just for that issue.

Do you know a way I can go about uncommitting that last commit so it would just be the first commit that addresses the duplicate text that will be there?

I checked stackoverflow and the solutions I got was to use git reset --hard HEAD^. I haven't tried it yet.

DominusKelvin commented 1 year ago

Hmm 🤔

To do that I think you can do this

git reset --soft HEAD~1 command

Or use the GitHub app to make things easier

d-a-ve commented 1 year ago

Yeah I did the former and it worked so now I just want to make my remote in sync with the main repo then submit a pull request.