sailscastshq / boring-stack

Ship JavaScript products with battle-tested technologies in days not weeks.
https://docs.sailscasts.com/boring-stack/getting-started
MIT License
427 stars 18 forks source link

typo: mention of "Vue 3" in README for mellow-react and mellow-svelte #26

Closed babblebey closed 1 year ago

babblebey commented 1 year ago

You can find mention of "Vue 3" on the READMEs of the mellow-react and mellow-svelte.

templates\mellow-react\README.md

This template should help get you started developing with a modern Sails fullstack application with Inertia and Vue 3

templates\mellow-svelte\README.md

This template should help get you started developing with a modern Sails fullstack application with Inertia and Vue 3

It should read the respective libraries for sure.

babblebey commented 1 year ago

Changing the "Vue 3" to respective libraries "React" or "Svelte" in their templates.

This can seat as a good-first-issue

DominusKelvin commented 1 year ago

Thanks for catching this. The copy of these README will be significantly changed and as a side effect, the issue you raised will be addressed @babblebey

But for now since we are still scaffolding the counter apps, you can go ahead and open a PR to fix this

Emmo00 commented 1 year ago

Hello @babblebey and @DominusKelvin , I understand this is a little temporary fix as more content is gonna be added soon, but don't you think we should do it anyways?

DominusKelvin commented 1 year ago

Yeah any one is welcomed to open a PR to fix this. You can also touch the package.json if respective templates to update their name as well. Thanks

Emmo00 commented 1 year ago

I'm sorry, i don't see what needs to be changed in the package.json file. i was thinking it was the description but that is probably right. image

DominusKelvin commented 1 year ago

@Emmo00 the name that's currently set to svelte should be "mellow-svelte" or "mellow-react" and "mellow-vue" respectively

Emmo00 commented 1 year ago

oh.. thanks