Closed d-a-ve closed 5 months ago
Awesome @d-a-ve Ii will have Geekiedj review this.
Alright, sounds good @DominusKelvin
Hi @d-a-ve, thank you for your contribution. Instead of using [chore], [feat], or [fix] prefixes in the issue title, it's recommended to use labels for categorization. These prefixes are commonly used in commit messages or PR titles, not when creating an issue.
Okay, so labels such as [bug], [doc], etc. Or what kind of labels do you have in mind @geekiedj
Okay, so labels such as [bug], [doc], etc. Or what kind of labels do you have in mind @geekiedj
yeah labels such as "good first issues, enhancement, etc. You can find them on the right of this page or better still, you could check the issues tab to understand what I'm talking about
Okay, so labels such as [bug], [doc], etc. Or what kind of labels do you have in mind @geekiedj
yeah labels such as "good first issues, enhancement, etc. You can find them on the right of this page or better still, you could check the issues tab to understand what I'm talking about
I have seen them; bug, enhancement, good-first-issue, wont-fix etc. So these should be added to the issue, alright. Will the person be the one to select the issue label that fits or that will be done by the maintainer? @DominusKelvin @geekiedj
Okay, so labels such as [bug], [doc], etc. Or what kind of labels do you have in mind @geekiedj
yeah labels such as "good first issues, enhancement, etc. You can find them on the right of this page or better still, you could check the issues tab to understand what I'm talking about
I have seen them; bug, enhancement, good-first-issue, wont-fix etc. So these should be added to the issue, alright. Will the person be the one to select the issue label that fits or that will be done by the maintainer? @DominusKelvin @geekiedj
I assume you're trying to add a create issue
in the contributing. md guideline right? if that's correct, then all you have to do will be to ask(i.e, include that step in the contributing guide) whoever might be interested in creating an issue in the repo (IF, the issue doesn't exist) to include labels to the issue that way other contributors will understand what the issue intends to solve as well as a descriptive title and comment of course.
Does that make sense? @d-a-ve
Yes this is great, I understand. So the person picks the labels that fits the issue.
I will make a pull request later in the day for the changes.
@geekiedj What do you think? It seems the person that creates an issue cannot assign the labels themselves...unless I do not know how to do it
@geekiedj What do you think? It seems the person that creates an issue cannot assign the labels themselves...unless I do not know how to do it
Oh! Just checked now, that's true. It has to do with some permission things. If that be the case, you could take that option out and just make a PR.
Okay, I didn't add it to the last commit I sent, I was waiting for your feedback. Can you check the issue section I created in the last commit I made? So we can be sure it is okay before merging.
Okay, I didn't add it to the last commit I sent, I was waiting for your feedback. Can you check the issue section I created in the last commit I made? So we can be sure it is okay before merging.
Okay, I didn't add it to the last commit I sent, I was waiting for your feedback. Can you check the issue section I created in the last commit I made? So we can be sure it is okay before merging.
Here is the commit https://github.com/sailscastshq/boring-stack/commit/5ef7466c21adffacbe40123460492d5ac01a980b
Okay, I didn't add it to the last commit I sent, I was waiting for your feedback. Can you check the issue section I created in the last commit I made? So we can be sure it is okay before merging.
Here is the commit 5ef7466
I thought I replied already.Apologies. I think this looks good. Let's see what @DominusKelvin thinks?
Alright. @DominusKelvin What do you think?
@d-a-ve thanks for working on this, I left a couple of suggestions for you :)
@DominusKelvin I have made the changes. How is it now?
Hi @DominusKelvin please have you been able to check the change i did with the new commit?
Closes #24