search

sailscastshq / boring-stack

Ship JavaScript products with battle-tested technologies in days not weeks.
https://docs.sailscasts.com/boring-stack/getting-started
MIT License
390 stars 19 forks source link

Corrected the link to webpack #58

Closed delight closed 9 months ago

delight commented 11 months ago

Link was pointing to an akward page

DominusKelvin commented 11 months ago

Hey @delight great job on this PR. However you didn't create an issue first as recommended by the CONTRIBUTING.md guide. Could you have a look at it and then tailor the PR as recommended?

delight commented 11 months ago

@DominusKelvin isn't that a little idiomatic for such a small obvious error fix?

Ultimately you can keep the error, or fix it yourself and claim that you found / fixed it 🤣

up to you ... it is good to have contribution guide lines but you should also think pragmatically.

BTW: Are there any plans to get the Svelte part up to feature parity with the others or is it just a "we have svelte too" thingy?

DominusKelvin commented 11 months ago

Got you, for all supported UI frameworks they will all have the mellow templates and all future templates

For your PR please do create the issue as recommended by the CONTRIBUTING.md guide

Thanks

delight commented 11 months ago

https://github.com/sailscastshq/boring-stack/issues/61

delight commented 11 months ago

image

Now I know why it is called the boring-stack 😂

DominusKelvin commented 9 months ago

sorry for the long wait @delight. Now merging