New customer is not assigned to configured list

sailthru / sailthru-magento2-extension

Sailthru extension for Magento 2

2 stars 12 forks source link

New customer is not assigned to configured list #17

Closed sshymko closed 3 years ago

sshymko commented 7 years ago

Preconditions:

Multi-store setup with the following websites: A, B, C
Sailthru API Key and Secret Key are configured on the website level
System configuration in scope of the website A: Sailthru > Lists > Lists > Customer Sign-Up Lists: Master List

Steps to reproduce:

Register new customer account on the A website, for example, test@example.com
Check your mailbox
Log in to Sailthru admin panel
Locate the customer record
Notice Recent Transactional Mails
Notice Natural Lists the customer is assigned to

Actual result:

Sailthru lists emails of Status = "delivered" and Template = "Magento Generic" at step 5
Sailthru shows empty list at step 6

silverman63 commented 7 years ago

Hi @sshymko, thanks for submitting. I'm currently looking into it and trying to reproduce.

For additional information, can you confirm the API Key and Secret are properly configured to the right account per scope?

The observer may be retrieving the wrong storeConfig information and be sending the data to a different account.

silverman63 commented 7 years ago

In addition, are API keys set at default scope as well as website? And what version are you running?

silverman63 commented 7 years ago

Hi @sshymko, I've been investigating and I'm 95% sure it has do with how the plugin retrieves scope (see here).

I believe this for two reasons:

The Sailthru logs show proper list registration calls for one of your stores
I started noticing strange behavior in the API key verification screen at different scopes.

Will continue to explore, and would be glad to accept any recommendations as well.

sshymko commented 7 years ago

@silverman63 Both API Key and Secret Key are configured on the website level. Added to the Preconditions.

silverman63 commented 7 years ago

Hi @sshymko, I've just created #19 which should fix scope configuration problems. Can you see if this resolves the issue? You can do it via composer via composer require sailthru/sailthru-magento2-extension dev-ScopeConfigFix or GitHub.

I've had issues fully replicating multisite in my sandbox, but will continue to get it setup. I think this may resolve your issues, though.

sshymko commented 7 years ago

Thanks @silverman63! We've deployed the dev-ScopeConfigFix for testing. Will let you know whether it resolves the issue.

alexpoletaev commented 7 years ago

Hello @silverman63 ! I found an issue with new changes you made, the config retrieval on the front end does not work with the multi website Magento instance. Please check the #20 pull request, this solved this issue on our website. Thanks.

silverman63 commented 7 years ago

Hi @alexpoletaev, thanks for submitting that. I will test it today.

To be clear, the PR resolves the issue with list signups, or purely with config retrieval?

silverman63 commented 7 years ago

Also: this branch does not include #16 by @sshymko, but will add add for final version.

sshymko commented 7 years ago

We use a workaround for #16 for now.

silverman63 commented 7 years ago

Hi @sshymko, @alexpoletaev to clarify, with all of the above, are you still unable to properly add users to a list?

sshymko commented 7 years ago

@silverman63, No, the issue with the mailing lists stands. PR #20 only fixes the order/subscription confirmation emails broken by #17.

silverman63 commented 3 years ago

Hi! Looks like this thread was never closed. Are you still experiencing issues here?

sshymko commented 3 years ago

With #16 merged, the issue should be resolved. Closing.