search

sailthru / sailthru-magento2-extension

Sailthru extension for Magento 2
2 stars 12 forks source link

SAIL-32: CHA-446 Magento 2: Zend Log deprecated in M2.4.3 #84

Closed giraclion closed 3 years ago

giraclion commented 3 years ago
eshih-sailthru commented 3 years ago

@giraclion @sofvlad Do we need to change the semantic versioning in ( "version": "2.2.0" in composer.json) and ( <module name="Sailthru_MageSail" setup_version="2.2.0" inetc/module.xml) to match PR's updated Magento's version of 2.4.3?

giraclion commented 3 years ago

@eshih-sailthru We do not have a defined versioning yet, unfortunately we did not align on that. Sailthru extension at the beginning had its own versioning not tight to Magento version. It started from v1.0.0 back then. At some point we started to treat Sailthru 1.x.x as legacy versions for Magento 2.2.x and 2.3.0-2.3.2 versions. Currently any 2.x.x Sailthru version corresponds to any M2 versions v2.3.3+. So currently you simply can bump extension version to the next, for ex. v2.2.1.

But I suggest the next versioning in the future, that would be tight to M2 versions, but yet have its own patch versioning, for example:

Option 1 - Magento vX.X.X = Sailthru vX.X.X:
Magento v2.2.1 -> Sailthru v2.2.1.0, v2.2.1.1 ... v2.2.1.45 etc
Magento v2.2.5 -> Sailthru v2.2.5.0, v2.2.5.1 ... v2.2.5.45 etc
....
Magento v2.4.3 -> Sailthru v2.4.3.0, v2.4.3.1 ... v2.4.3.45 etc

Option 2 - Magento vX.X = Sailthru vX.X:
Magento v2.2.x -> Sailthru v2.2.0, v2.2.1 ... v2.2.45 etc
Magento v2.3.x -> Sailthru v2.3.0, v2.3.1 ... v2.3.45 etc
....
Magento v2.4.x -> Sailthru v2.4.0, v2.4.1 ... v2.4.45 etc

This way we can release different Sailthru versions and support multiple M2 "major" versions.

azinger-sailthru commented 3 years ago

Thanks for the quick reply, @giraclion ! On this particular PR, it looks like we must change the versions in the files, as @eshih-sailthru indicated, yes?

giraclion commented 3 years ago

@azinger-sailthru correct, in composer.json and in etc/module.xml

eshih-sailthru commented 3 years ago

@giraclion can we ask you to make the semantic version change directly on the PR (the composer.json and in etc/module.xml file) since it would be easier for us on our end? bumping the semantic version up to 2.2.1 is a good idea and feel free to incorporate patch versioning as you see fit!

giraclion commented 3 years ago

@eshih-sailthru just updated the version in current PR.

eshih-sailthru commented 3 years ago

@giraclion I just release the PR from the current repo on sailthru's end. Would definitely appreciate if you can verify the deploy changes in prod since our team currently don't have the magento sandbox setup?

giraclion commented 3 years ago

@eshih-sailthru We've deployed the solution on our local sandbox server with vanilla Magento v2.4.3 and all works fine.