275 jira downloader without jiragiler

[Ssunoo2]

I've created a new function: R/Jira.R/download_and_save_jira_issues.rmd. This function interfaces with the JIRA Rest API at the search endpoint and uses a username and password(atlassian token) to authenticate each request. The function calls are located in vignettes/download_jira_issues.rmd. Each file has the issues for each loop of pagination in it.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 139 lines in your changes are missing coverage. Please review.

Project coverage is 38.08%. Comparing base (2bc8d14) to head (622d3e0). Report is 2 commits behind head on master.

:exclamation: Current head 622d3e0 differs from pull request most recent head e6c3d91. Consider uploading reports for the commit e6c3d91 to get more accurate results

Files	Patch %	Lines
R/jira.R	0.00%	139 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #279 +/- ## ========================================== - Coverage 39.79% 38.08% -1.72% ========================================== Files 20 20 Lines 3091 3230 +139 ========================================== Hits 1230 1230 - Misses 1861 2000 +139 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[carlosparadis]

@Ssunoo2 You have to get R-Cmd-Check and test-coverage to pass here. Also, when that happens, request code review of one of you team members. Once it is a pass, you can request mine.

[Ssunoo2]

I'm having some issues passing the checks. Here is a picture of what I am seeing on my end:

It says that the lines I added to the Jira.R "are not covered by tests". I was wondering if you could shed some light on what that meant

[carlosparadis]

@Ssunoo2 Don't worry about codec; this is a tool that monitors if you are unit testing the code you are adding. The important part is the check and unit test passing, which they are. Once we add the fake data generator unit tests, that should pass.

Your next step is request via the PR interface one of your team mates to code review, for them to add revisions, and then select accept or reject for your changes. Then comes my turn.

[carlosparadis]

I am assuming this is still pending others review?

[Ssunoo2]

I am assuming this is still pending others review?

Yes, I am waiting for Ian and Anthony's reviews

[carlosparadis]

@Ssunoo2 I see I was requested for review, but I still see the NEWS.md and _pkgdown.yml are in conflict. You need to resolve these before I can review it.

[Ssunoo2]

@carlosparadis Thanks for pointing that out. I had resolved conflicts locally and didn't notice that these conflicts were here on the page. Conflicts should be resolved now.

[carlosparadis]

@Ssunoo2 Is the commit changing the function for data range down to minute level added yet? Just want to know if ready or code review or not.

[Ssunoo2]

@carlosparadis The notebook does specify date range down to minute. I put comments in the notebook for the formatting for date ranges w/ a link to https://support.atlassian.com/jira-software-cloud/docs/jql-fields/#Created that describes the formatting in greater detail.

[Ssunoo2]

One previous issue that the refresher had was that it would not work if the file designated was empty. Here, I added a check to see if the file is empty or not and download all issues if it is. If it is not empty, the refresher runs as normal:

 contents <- list.files(path = file_path)

    if(length(contents) == 0) {
       # Download all issue data
   } else {
       # Refresh
  }

[carlosparadis]

Working on this, please do not commit to this branch.

[carlosparadis]

Great, all checks are passing : ) I will test the code and review it one last time tomorrow.