sailuh / kaiaulu

An R package for mining software repositories
http://itm0.shidler.hawaii.edu/kaiaulu
Mozilla Public License 2.0
20 stars 13 forks source link

230 Create Config get() Interface #288

Closed anthonyjlau closed 1 week ago

anthonyjlau commented 7 months ago

If a change is made in a configuration file, then every notebook that uses that configuration file has to be changed. In order to centralize the process and make it easier to change configuration files, the R/config.R file will store "get" functions that get the fields from the config files. These get functions can be used in place of the hard coded variable assignments. It will also make it easier to update changes to config files as only the functions in R/config.R need to be updated.

codecov[bot] commented 7 months ago

Codecov Report

Attention: Patch coverage is 0% with 244 lines in your changes are missing coverage. Please review.

Project coverage is 35.90%. Comparing base (2bc8d14) to head (ba27309). Report is 3 commits behind head on master.

Files Patch % Lines
R/config.R 0.00% 244 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #288 +/- ## ========================================== - Coverage 39.79% 35.90% -3.89% ========================================== Files 20 21 +1 Lines 3091 3545 +454 ========================================== + Hits 1230 1273 +43 - Misses 1861 2272 +411 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Ssunoo2 commented 7 months ago

Nice work!

carlosparadis commented 6 months ago

@anthonyjlau Error occurs on my local machine too when I try to build it fails with the following error:

Error in parse(outFile) : 
  /Users/cvp/Desktop/kaiaulu/kaiaulu/R/config.R:770:68: unexpected symbol
769: 
770:   key <- conf[["issue_tracker"]][["bugzilla"]][["project_key_index"project_key
carlosparadis commented 1 month ago

Nice to see these checks passing at last, thank you for merging the master to fix on this end!

crepesAlot commented 1 month ago

Made 1 new commit after group meeting, updated NEWS.md and a very minor change to the mailing_list.

carlosparadis commented 1 week ago

GitHub Actions fail due to its own dependency problems. This commit passes local checks, tests and compile docs. Some notebooks were prefixed to _ until #282 is merged as the logic of parse_github_replies was modified, and we wanted the configs to reflect the code changes there.