saimn / sigal

yet another simple static gallery generator
http://sigal.saimon.org/
MIT License
882 stars 169 forks source link

inclusion of extra themes #247

Open samuelallan72 opened 7 years ago

samuelallan72 commented 7 years ago

Hi,

I use sigal for a photo gallery that integrates with a static site built with jekyll and lunr js search. To acheive this, I built a custom theme which can be viewed at swalladge/sigal-jekyll. It's not exactly polished yet for publishing quality, but wondering if anyone maintaining sigal would be interested in it - either for linking to from your docs (I can't seem to find any other alternate themes?) or considering including with this project.

Interested to hear anyone's thoughts. 😃

saimn commented 7 years ago

Hi @swalladge , To my knowledge there are not many alternative themes, which is a bit sad. I'm happy to include more choices directly in sigal, to make it easier for users. And if someday there are too many themes we can consider splitting them from the main package, but I doubt it!

samuelallan72 commented 7 years ago

@saimn great! I'll see about polishing it up and submitting a pull request. :)

153957 commented 6 years ago

I have also created my own version ( https://github.com/153957/153957-theme/ ) of the galleria theme. Perhaps we could add a list of all known custom themes to the docs ( http://sigal.saimon.org/en/latest/themes.html ), and also indicate the existence of those themes in the readme.

saimn commented 6 years ago

@153957 - Yes sure, we could add a (sub)section for external themes. Please feel free to do so.

I saw that your theme must be activated using the plugins setting instead of theme. Maybe this could be improved ? I understand that you need of way to specify the theme path, I think a cleaner way would be something like this:

import 153957_theme
theme = 153957_theme.get_path()

However I don't get what the 153957_theme.full_menu plugin is for ?

krylovsk commented 5 years ago

FWIW, here's another theme with justified gallery: https://github.com/krylovsk/sigal-justlight

saimn commented 5 years ago

@krylovsk - Nice! I added a link in the wiki.