saimn / sigal

yet another simple static gallery generator
http://sigal.saimon.org/
MIT License
885 stars 168 forks source link

Non-py files not getting installed when installing release tarball #522

Closed bazuchan closed 2 months ago

bazuchan commented 3 months ago

Setuptools uses .git metadata to detect data-files. When installing from releases tarball, there is no git metadata and only *.py files getting installed.

https://setuptools.pypa.io/en/latest/userguide/datafiles.html

saimn commented 3 months ago

I cannot reproduce, can you give more details on your environnement, the command you run etc ?

bazuchan commented 3 months ago

Ubuntu 24.04 Using release tarball https://github.com/saimn/sigal/archive/refs/tags/2.4.tar.gz Commenting out setuptools_scm in pyproject.toml (not intended use case, but anyway) Running python -m build will produce wheel containing only .py files

saimn commented 2 months ago

That's a git archive but not a release archive, which is available on PyPI. The git one is missing a few files (version, .egg-info). https://pypi.org/project/sigal/2.4/#files

❯ diff -u <(tar tf sigal-2.4-github.tar.gz) <(tar tf sigal-2.4-pypi.tar.gz) 
--- /proc/self/fd/11    2024-07-08 19:20:46.501583948 +0200
+++ /proc/self/fd/14    2024-07-08 19:20:46.504917364 +0200
@@ -10,6 +10,7 @@
 sigal-2.4/AUTHORS
 sigal-2.4/CONTRIBUTING.rst
 sigal-2.4/LICENSE
+sigal-2.4/PKG-INFO
 sigal-2.4/README.rst
 sigal-2.4/docs/
 sigal-2.4/docs/Makefile
@@ -29,6 +30,7 @@
 sigal-2.4/docs/plugins.rst
 sigal-2.4/docs/themes.rst
 sigal-2.4/pyproject.toml
+sigal-2.4/setup.cfg
 sigal-2.4/src/
 sigal-2.4/src/sigal/
 sigal-2.4/src/sigal/__init__.py
@@ -200,8 +202,16 @@
 sigal-2.4/src/sigal/themes/photoswipe/templates/album_list.html
 sigal-2.4/src/sigal/themes/photoswipe/templates/base.html
 sigal-2.4/src/sigal/utils.py
+sigal-2.4/src/sigal/version.py
 sigal-2.4/src/sigal/video.py
 sigal-2.4/src/sigal/writer.py
+sigal-2.4/src/sigal.egg-info/
+sigal-2.4/src/sigal.egg-info/PKG-INFO
+sigal-2.4/src/sigal.egg-info/SOURCES.txt
+sigal-2.4/src/sigal.egg-info/dependency_links.txt
+sigal-2.4/src/sigal.egg-info/entry_points.txt
+sigal-2.4/src/sigal.egg-info/requires.txt
+sigal-2.4/src/sigal.egg-info/top_level.txt
 sigal-2.4/tests/
 sigal-2.4/tests/conftest.py
 sigal-2.4/tests/sample/