sainnhe / edge

Clean & Elegant Color Scheme inspired by Atom One and Material
MIT License
884 stars 57 forks source link

Dark mode terminal colors #24

Open kristijanhusak opened 3 years ago

kristijanhusak commented 3 years ago

Hello,

today I was using dark mode for a bit (I'm using light mode 99% of the time), and noticed while running some tests that some part of text was not visible. I investigated a bit and noticed that terminal colors are completely the same between 0-7 and 8-15. My test runner uses color8 to display foreground color for the test specs (mocha), which in dark mode causes text and background to be exactly the same. I don't have this issue in light mode.

I think there should be some difference between 0-7 and 8-15 palette. For example, if you check kitty color scheme example,it also uses different colors https://sw.kovidgoyal.net/kitty/conf.html#the-color-table