sainnhe / edge

Clean & Elegant Color Scheme inspired by Atom One and Material
MIT License
902 stars 57 forks source link

NvimTree: bad diagnostics symbols highlight #38

Closed xeluxee closed 3 years ago

xeluxee commented 3 years ago

Operating system/version

linux

Terminal emulator/version

kitty

$TERM environment variable

xterm-kitty

Tmux version

No response

Feature matrix

not related

Minimal vimrc that can reproduce this bug.

Simply install edge

Steps to reproduce this bug using minimal vimrc

  1. Open a file and wait for neovim builtin LSP to start
  2. Type something (some errors) to make diagnostics arise
  3. Open NvimTree buffer :NvimTreeFindFile
  4. Look at the diagnostics symbol near the file name

Expected behavior

This screenshot is taken while using material.nvim, and it shows the correct behavior

error-material

Actual behavior

This screenshot is taken while using edge

error-edge

As you can see error symbol is undercurled and not red

sainnhe commented 3 years ago

Please provide minimal vimrc next time, I don't use nvim-tree and nvim-lspconfig and my config can't reproduce your bug.

sainnhe commented 3 years ago

Screenshot_20211110_164617

I can't reproduce.

xeluxee commented 3 years ago

Please provide minimal vimrc next time, I don't use nvim-tree and nvim-lspconfig and my config can't reproduce your bug.

Sorry I thought it wasn't strictly necessary

I can't reproduce.

You should enable diagnostics in setup function:

require'nvim-tree'.setup {
  diagnostics = {
    enable = true,
    icons = {
      hint = "",
      info = "",
      warning = "",
      error = "",
    }
  },
}

I think #39 should solve it

xeluxee commented 3 years ago

Screenshot_20211110_164617

Offtopic, what font are you using here?

sainnhe commented 3 years ago

Fixed via https://github.com/sainnhe/edge/commit/8540e798b01fd6a3c80ffa4a1930d9733e294b34


The font is operator mono.