sainnhe / edge

Clean & Elegant Color Scheme inspired by Atom One and Material
MIT License
869 stars 56 forks source link

g:fzf_colors on light background makes the text invisible in fzf window #5

Closed janlazo closed 4 years ago

janlazo commented 4 years ago

g:fzf_colors is okay in dark background.

Tested with fzf.vim, GFiles command, termguicolors on, light background.

Workaround is to use an autocmd to unlet g:fzf_colors after setting the colorscheme.

sainnhe commented 4 years ago

I'm unable to reproduce this.

Minimal configuration:

if has('nvim')
    set runtimepath^=~/.vim runtimepath+=~/.vim/after
    let &packpath = &runtimepath
endif
call plug#begin('~/.cache/vim/plugins')
Plug 'junegunn/fzf'
Plug 'junegunn/fzf.vim'
Plug 'sainnhe/edge', { 'as': 'vim-color-edge' }
call plug#end()

set termguicolors
set background=light

augroup testFzf
    autocmd!
    autocmd ColorScheme * unlet g:fzf_colors
augroup END

colorscheme edge

Demo:

demo

I think this is visible enough, please provide steps to reproduce it.

In addition, why do you want to unlet g:fzf_colors? This color scheme is optimized specifically for fzf.

janlazo commented 4 years ago

nvim-qt_nvim-0 5 0_ubuntu

neovim-qt, nvim 0.5.0, Ubuntu 16.04

gvim_vim-8 1 2380_win10

GVim, Vim 8.2 Windows 10 (Edge VM). I can't replicate the invisible text on the VM. I saw it on my Windows work machine only so I'll add the screenshot if needed next week.

I don't want to unlet g:fzf_colors but I don't know how else to avoid it. Perhaps set g:fzf_colors only if not running on Windows.

janlazo commented 4 years ago

nvim-qt_nvim-0 5 0_win10

nvim-qt, nvim 0.5.0, Windows 10 (Edge VM). I reproduced here.

janlazo commented 4 years ago

I'll mitigate the text,background color issue in upstream instead.