Closed markstory closed 2 years ago
Does this work for you?
diff --git a/autoload/edge.vim b/autoload/edge.vim
index cf6087e..268f44d 100644
--- a/autoload/edge.vim
+++ b/autoload/edge.vim
@@ -152,9 +152,7 @@ function! edge#highlight(group, fg, bg, ...) "{{{
\ a:1 :
\ 'NONE')
\ 'cterm=' . (a:0 >= 1 ?
- \ (a:1 ==# 'undercurl' ?
- \ 'underline' :
- \ a:1) :
+ \ a:1 :
\ 'NONE')
\ 'guisp=' . (a:0 >= 2 ?
\ a:2[0] :
Does this work for you?
Yes it does!
Thank you!
Operating system/version
macOS Big Sur 11.6
Terminal emulator/version
Kitty 0.24.3
$TERM environment variable
xterm-kitty
Tmux version
tmux 3.2a
Feature matrix
Minimal vimrc that can reproduce this bug.
Steps to reproduce this bug using minimal vimrc
Thank you for publishing this, I'm really loving the colorscheme. This is less of a bug report and more of a question/proposal.
Expected behavior
I was hoping to see undercurls used when the highlight groups say
undercurl
.Changing line 156 of the cited block to
'undercurl'
updates the output to use undercurls correctly. Would you be open to using actual undercurls used (based on a configuration flag that defaults to the current behavior)?Actual behavior
I've noticed that the
edge#highlight
convertsundercurl
tounderline
when generating the highlight definition. This results in a straight underline being used:I tracked this down to this block:
https://github.com/sainnhe/edge/blob/825421f15fbba5ccf7ab374290369e53c915c60c/autoload/edge.vim#L155-L157