search

sainnhe / everforest

🌲 Comfortable & Pleasant Color Scheme for Vim
MIT License
2.92k stars 132 forks source link

lsp hover window background improvement? #65

Closed xfyuan closed 2 years ago

xfyuan commented 2 years ago

First thank you for the great colorscheme for Vim/Neovim! I've used it more than 2 years. 👍

Maybe there's an improvement for its lsp hover window's effect?

The default hover document window looks like this:

截屏2022-04-29 00 02 30

There's some place between the border and the background color area, it's not so good, I think.

After some research, I found we can set the NormalFloat background to none to solve that problem. The code position is:

https://github.com/sainnhe/everforest/blob/1e594a20ce382bcc55c0e3fd488e90ca68dffb32/colors/everforest.vim#L130

And the new result is like this:

截屏2022-04-29 00 01 48

Does it looks better?

sainnhe commented 2 years ago

Which plugin are you using?

NormalFloat is used by many other plugins, change this hi group will change all float window background.

We should change the background of border instead.

sainnhe commented 2 years ago

Does https://github.com/sainnhe/everforest/commit/f748681a3fac2496aedf694f5bd09a30f80cd3c0 fix this issue for you?

xfyuan commented 2 years ago

I just updated to the latest version, found it looks like this now:

image

I thinks it's better than before. But as my own opinion, I like the hover window without the bg2 background color more than above version:)

xfyuan commented 2 years ago

Any way, current version is better than old one. Thank you.

Maybe this issue can be closed unless anyone has other thought about it.