sainnhe / gruvbox-material-vscode

Gruvbox Material for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=sainnhe.gruvbox-material
MIT License
225 stars 21 forks source link

Always required to reload on remote container #49

Closed yoshida-m-3 closed 3 years ago

yoshida-m-3 commented 3 years ago

Settings

{
  "gruvboxMaterial.darkContrast": "hard",
  "gruvboxMaterial.darkCursor": "yellow",
}

Steps to reproduce this bug

Whenever I connect with the remote container extension, I get a notification that it needs to be reloaded. Also, if you do not reload, the json settings will not be reflected.

image

sainnhe commented 3 years ago

When the settings.json is changed, the /themes/*.json files are regenerated based on your new settings, so you need to reload to apply the new settings.

I'm not sure how the container extension works, but looks like whenever you connect to it, your settings.json will be applied, and since your settings is not the default settings, so the /themes/*.json will be regenerated.

So maybe remove the settings for gruvbox-material, or try another gruvbox theme instead.

I don't use vscode very much and I'm not an experienced user, so I'm unable to fix this, but PR is always welcome :)

Btw, the typescript code for this theme is based on Binaryify/OneDark-Pro, you can try this theme in remote container and see if this bug can reproduce in it.

sainnhe commented 3 years ago

This should be fixed via #52

github-actions[bot] commented 3 years ago

This issue has been closed, the fix/feature will be available in the next release.

To get the update immediately, you can compile this extension from source code:

Requirements

  1. git
  2. nodejs

Steps

Open your terminal emulator and execute the following commands:

  1. Clone the repository: git clone --depth 1 https://github.com/sainnhe/gruvbox-material-vscode.git && cd gruvbox-material-vscode
  2. Install node modules: npm ci
  3. Compile and package this extension to a .vsix file: npm run package
  4. Install from this .vsix file: How to install VS code extension manually? - Stack Overflow