search

sainnhe / gruvbox-material

Gruvbox with Material Palette
MIT License
1.96k stars 166 forks source link

feat(ts): add `@type.definition` and `@type.qualifier` #155

Closed koka831 closed 2 years ago

koka831 commented 2 years ago

This PR adds @type.definition and @type.qualifier, that are used for Rust (at least, from https://github.com/nvim-treesitter/nvim-treesitter/commit/00b42ac6d4c852d34619eaf2ea822266588d75e3).

antoineco commented 2 years ago

This sounds reasonable, thanks!

For posterity, could you please share a screenshot showcasing in what context these hightlights are being used?

koka831 commented 2 years ago

Thank you for review! is it okay?:)

image

FWIW before https://github.com/nvim-treesitter/nvim-treesitter/commit/00b42ac6d4c852d34619eaf2ea822266588d75e3 @type.qualifier like mut keyword is highlighted in Red, so I chose colors to remain the same before.

antoineco commented 2 years ago

Thanks for the screenshot!

Last request for opinion from @sainnhe before merging: since red is already widely used for identifiers, maybe you would like to apply a different color to these qualifier and definition symbols? Same highlight as Type maybe?

koka831 commented 2 years ago

@antoineco I updated them to yellow so I'll squash if it's necessary.

antoineco commented 2 years ago

That actually not only looks better now, but it's also fitting the semantics :+1:

No need to squash, GitHub will do it!

sainnhe commented 2 years ago

IMO orange might be better, I use orange in operators and modifiers.