sainnhe / gruvbox-material

Gruvbox with Material Palette
MIT License
1.96k stars 166 forks source link

[Feature Request] More colors #156

Closed EricDriussi closed 2 years ago

EricDriussi commented 2 years ago

Hi there! Loving the theme, thanks for putting in the work.

So I'm not quite sure how to express this, I'll do my best: For any given code snippet, there seems to be a bit of color repetition for seemingly different elements.

So for example, with catppuccin: image

While gruvbox-material: image

(Notice for example lines 7, 15, 16 and 21)

Mind you this is with the same config, except for gruvbox-material specifics that don't seem to affect the output, like

set termguicolors
set background=dark
let g:gruvbox_material_background = 'hard'
let g:gruvbox_material_foreground = 'mix'
let g:gruvbox_material_better_performance = 1
let g:gruvbox_material_enable_italic = 1
let g:gruvbox_material_visual = 'background'

I'm not sure if this is the expected behavior but it just feels like something is missing.

I understand that versions and configs are not really relevant for this issue, although if mistaken I can attach whatever information might be needed.

sainnhe commented 2 years ago

Variables are expected to be White, I've added some new tokens in https://github.com/sainnhe/gruvbox-material/commit/421ccc28df2b5c8aef06b40160d539684fd1e771 , could you get it a try?

EricDriussi commented 2 years ago

@sainnhe That's exactly what I was referring to, looks awesome! Thanks a lot!!