[FEAT] diagnostic virtual text highlight support

[baggiponte]

Users can already set gruvbox_material_diagnostic_line_highlight and gruvbox_material_diagnostic_text_highlight. How about adding a gruvbox_material_diagnostic_virtual_text_highlight to enable highlighted virtual text? Aside from my personal preference, I see it is quite common in other themes.

[sainnhe]

What do you mean by "highlighted virtual text"? Isn't it already been highlighted?

[baggiponte]

Thanks for the reply! When I toggle gruvbox_material_diagnostic_virtual_text I get virtual text in the same color as the warning. gruvbox_material_diagnostic_text_highlight highlights the diagnosed line. The feature I am describing should look like this:

Maybe there's something that overrides the highlight groups, I guess? For example, toggling gruvbox_material_diagnostic_line_highlight does not change anything for me.

[sainnhe]

I'm going to support this when I have time. Also, PR is welcome :)

[baggiponte]

Would love to! I have tried navigating the codebase but I am not too well-versed in vimscript. I guess I could help with the lua part! 💪🏼

[sainnhe]

Thanks! But this color scheme is mostly written in Vim Script. You can try to read the code if you are interested in it.

[antoineco]

@baggiponte I experimented with this a little bit, and here is the result (before/after):

Is that the result you expect?

[baggiponte]

Hi @antoineco, sorry for the late reply. Thanks for working this out - this is what I had in mind!