sainnhe / gruvbox-material

Gruvbox with Material Palette
MIT License
1.9k stars 164 forks source link

DiffText become invisible in dark background #179

Closed jerryyin closed 1 year ago

jerryyin commented 1 year ago

I have done the following steps before reporting this issue:

$TERM environment variable

screen-256color

Feature matrix

vim 9

Minimal vimrc that can reproduce this bug.

set background=dark
let g:gruvbox_material_background='hard'

Steps to reproduce this bug using minimal vimrc

Change some text and launch diff window

Expected behavior

diff text should be visible

https://github.com/sainnhe/gruvbox-material/blob/3fff63b0d6a425ad1076a260cd4f6da61d1632b1/colors/gruvbox-material.vim#L119

Should be:

call gruvbox_material#highlight('DiffText', s:palette.none, s:palette.blue)

The bg0 makes the diff text to be invisible

Actual behavior

Hard to see diff text, as in:

image

When cursor is on the line with DiffText, it becomes almost invisible. I'm only able to see the text section when cursor isn't overlapping with the line.

antoineco commented 1 year ago

@jerryyin thanks for reporting, I'll link into this today.

antoineco commented 1 year ago

I'm not able to reproduce this issue:

image

Could you please share the output of :verbose hi DiffText? It should point at autoload/gruvbox_material.vim:

image

jerryyin commented 1 year ago

@antoineco Thanks for taking a look. I get the following with verbose hi DiffText:

DiffText xxx term=reverse ctermfg=234 ctermbg=109 guifg=#1d2021 guibg=#7daea3 Last set from ~/.vim/plugged/gruvbox-material/autoload/gruvbox_material.vim line 285

Please note that it becomes invisible only if my cursor overlaps with the diff line. If the cursorline is different, then diff text is as visible as your screen-clip.

antoineco commented 1 year ago

@jerryyin sorry for the very delayed answer. To me it seems like you have some plugin installed which automatically highlights the word under the cursor. If you tell us what plugins you are using we can maybe help, and support that plugin better.

antoineco commented 1 year ago

Closing due to inactivity. Feel free to reopen.