sainnhe / gruvbox-material

Gruvbox with Material Palette
MIT License
1.96k stars 166 forks source link

Setting g:gruvbox_material_better_performance=1 links StartifyHeader to Orange #74

Closed ndavd closed 3 years ago

ndavd commented 3 years ago

Is this normal behavior? Without setting the option I have: StartifyHeader guifg=#d4d4d4 But with that option enabled: StartifyHeader guifg=#d4d4d4 links to Orange

sainnhe commented 3 years ago

StartifyHeader should be linked to Orange regardless of whether g:gruvbox_material_better_performance is set.

Without setting the option I have: StartifyHeader guifg=#d4d4d4

This is unexpected, could you please follow the issue template to provide minimal vimrc and steps to reproduce this bug?

ndavd commented 3 years ago

So then it's probably due to my config. I have a colors.vim in autoload that is called in plugin. https://paste.sh/BQGSWC55#9xebSvlsIHfnNsYyt7xsdnCv

(it's probably not worth to make a minimal reproduce, since the problem is probably related to colors.vim)

ndavd commented 3 years ago

Question: Why did you make the colorscheme in a way that in order to change a highlight you have to call a function?

sainnhe commented 3 years ago

Because the color palette is too complex, see gruvbox_material#get_palette()

ndavd commented 3 years ago

The thing is. If I set the better performance option I can't seem to override that highlight. I tried hi! link Statusline NONE

sainnhe commented 3 years ago

See FAQ "How to use custom colors?"

ndavd commented 3 years ago

I did and it worked for other colors. I have pasted my colors.vim here https://paste.sh/BQGSWC55#9xebSvlsIHfnNsYyt7xsdnCv

sainnhe commented 3 years ago

So what's your question? What should I do with your colors.vim?

ndavd commented 3 years ago

It was just for you to take a look. If I don't set the performance option my StartifyHeader highlight works how I define it but if I set that better performance option it links it to Orange. And even when I link it to none how it is explained FAQ, it stays Orange nonetheless

ndavd commented 3 years ago

I'll try to make a reproduce I guess

ndavd commented 3 years ago

The problem is probably related to my config. Closing this.