search

sainnhe / gruvbox-material

Gruvbox with Material Palette
MIT License
1.96k stars 166 forks source link

fix(tree-sitter): make function and method bold #87

Closed dhruvmanila closed 3 years ago

dhruvmanila commented 3 years ago

I don't exactly know what TSFuncMacro or TSFuncBuiltin are, but should they be bold as well?

Also, should I update the code to do bold/italic highlights only if enable_bold/enable_italic is true, just like everywhere else?

sainnhe commented 3 years ago

Yeah, they should also be bold.

Plus, TSField and TSProperty also seem to be function name, I'm not very sure, maybe some debug is needed.

sainnhe commented 3 years ago

You don't need to manually set them to be bold or italic, just linking them to predefined hi groups like GreenBold should work, these hi groups are already controlled by the configuration options.

dhruvmanila commented 3 years ago

Plus, TSField and TSProperty also seem to be function name, I'm not very sure, maybe some debug is needed.

From tree-sitter help:

TSField For fields.

TSProperty Same as TSField.

You don't need to manually set them to be bold or italic, just linking them to predefined hi groups like GreenBold should work, these hi groups are already controlled by the configuration options.

Ah, yes completely missed that.

sainnhe commented 3 years ago

Thanks! I'm going to merge it.