Some terminal applications use bright black and bright white when
outputting with color. Because bright black and bright white are defined
as the same hex colors as their non-bright counterparts, text can
sometimes be rendered invisibly.
To get around this issue, I updated the terminal colors to use the
existing "bright" black/white colors already defined in the theme.
Here's what this looks like before/after using fzf and bat:
I've been enjoying this theme a lot but ended up running this patch in Vim and Iterm2 so I thought I'd open a PR and see if there's any interest in upstreaming it. If-so, happy to open a PR against the Iterm2 theme repo as well.
sainnhe
commented
3 years ago
Some terminal applications use bright black and bright white when outputting with color. Because bright black and bright white are defined as the same hex colors as their non-bright counterparts, text can sometimes be rendered invisibly.
To get around this issue, I updated the terminal colors to use the existing "bright" black/white colors already defined in the theme.
Here's what this looks like before/after using
fzfandbat:I've been enjoying this theme a lot but ended up running this patch in Vim and Iterm2 so I thought I'd open a PR and see if there's any interest in upstreaming it. If-so, happy to open a PR against the Iterm2 theme repo as well.