search

sainnhe / sonokai

High Contrast & Vivid Color Scheme based on Monokai Pro
MIT License
1.65k stars 119 forks source link

Add WinBar and WinBarNC #64

Closed registerGen closed 2 years ago

registerGen commented 2 years ago

Thank you for the colorscheme!

ref: neovim/neovim#18562

sainnhe commented 2 years ago

The default highlight of WinBar is

:hi WinBar
WinBar         xxx cterm=bold gui=bold

IMO it is reasonable enough, but WinBarNC is linked to WinBar so it's also white bold.

:hi WinBarNC
WinBarNC       xxx links to WinBar

Maybe changing it to grey will be better?

Could you try this:

:hi! link WinBarNC Grey
registerGen commented 2 years ago

Yep. That does make sense!

registerGen commented 2 years ago

Maybe a lighter background is better?

Here's my config:

vim.fn['sonokai#highlight']('WinBar', palette.fg, palette.bg3, 'bold')
vim.fn['sonokai#highlight']('WinBarNC', palette.grey, palette.bg3, 'bold')
sainnhe commented 2 years ago

IMO that will make the winbar more like a status line. I set laststatus=3 to avoid this, so I think using normal bg should be better.

registerGen commented 2 years ago

Well I think this should depend on what users want to do (for example, I use winbar to display the symbol path). You can just use normal bg as default and let users configure them to what they want.

sainnhe commented 2 years ago

Sorry for late reply, I'm so busy recently.

For small UI modification like this, adding a configuration option might be overkill. Users ought to use custom colors in their vimrc.

sainnhe commented 2 years ago

Done via https://github.com/sainnhe/sonokai/commit/93d6f268f65b8208a46e725da7e0cd759cc7b297

registerGen commented 2 years ago

Thanks!