search

sainnhe / sonokai

High Contrast & Vivid Color Scheme based on Monokai Pro
MIT License
1.65k stars 119 forks source link

fix(indent-blankline): Set a highlighted indent character color #75

Closed Mika412 closed 1 year ago

Mika412 commented 1 year ago

When using indent-blankline.nvim plugin, the context indent character wasn't being highlighted. This sets a default highlighting color.

Before: Screenshot 2022-10-24 at 00 25 36 fore:

After: Screenshot 2022-10-24 at 00 24 35

sainnhe commented 1 year ago
截屏2022-10-24 07 56 43

Nope. It is highlighted actually, but uses a brighter grey color. I didn't choose colors like red because this will make it easy to get distracted.

Mika412 commented 1 year ago

Setting such a barely noticeable color takes away the point of the feature. If people didn't want such a "distraction", they could just not enable the context highlighting. This way, we will need to overwrite the color, instead it being a part of the theme...

sainnhe commented 1 year ago

This design refered to VSCode themes, most of VSCode themes don't use things like red but use a brighter grey, and I think it's a good design.

Of course, this design won't satisfy everyone, you can fork this repository or customize the hi groups in your vimrc.

antoineco commented 1 year ago

@Mika412 Here is an example of how you can customize any highlight group in your vimrc, using an augroup: https://github.com/sainnhe/gruvbox-material/issues/139#issuecomment-1239121715

Mika412 commented 1 year ago

@antoineco I went with the following solution:

vim.cmd [[hi IndentBlanklineContextChar guifg=#fc5d7c gui=nocombine]]

Either way, thank you for the help, and sry about the useless PR