search

sainnhe / sonokai

High Contrast & Vivid Color Scheme based on Monokai Pro
MIT License
1.65k stars 119 forks source link

bufferline #78

Closed kaykhan closed 1 year ago

kaykhan commented 1 year ago

any support planned for a bufferline theme integration? https://github.com/akinsho/bufferline.nvim

sainnhe commented 1 year ago

It doesn't provide plugin specific highlight groups, so looks like this plugin can't be optimized at color scheme level.

https://github.com/akinsho/bufferline.nvim/blob/4ecfa81e470a589e74adcde3d5bb1727dd407363/doc/bufferline.txt#L709

antoineco commented 1 year ago

As far as I can tell, bufferline.nvim doesn't look all that bad with this coloscheme. All colors are derived from core highlight groups (with shading automatically applied), and therefore should already match the colorscheme.

Any specific concern?

image

Ref. https://github.com/sainnhe/everforest/issues/121 for a known issue with LSP diagnostic colors.

kaykhan commented 1 year ago

Hmm i cna't remember what this was in relation to, so this can be closed