Update highlight links for neovim lsp semantic tokens

jrwrigh commented 1 year ago

Note this is only for neovim 0.9+

Closes #85

antoineco commented 1 year ago

This looks good to me, thanks a lot! 🙌

Please allow me to have another cursory look with some code I work on regularly and I'll get back to you (possibly just approve and merge) at the end of the weekend.

antoineco commented 1 year ago

I found the following missing highlight links:

@lsp.type.macro still links to Macro instead of TSConstMacro
@lsp.type.decorator still links to Function instead of TSFunction
@lsp.type.namespace still links to Structure instead of TSNamespace

Moreover:

@lsp.type.typeParameter links to TSType but TSTypeDefinition seems more appropriate
@lsp.type.modifier links to TSOperator but TSTypeQualifier seems more appropriate

As a nit pick, I think it would be nice to sort those new highlights in alphabetical order, to keep them maintainable in case the list grows in the future.

Other than that, I think this patch is an excellent base for porting LSP Semantic Tokens support to gruvbox-material, everforest, and edge after sonokai.

jrwrigh commented 1 year ago

Gotcha. I'll update those links and put in alphabetical order.

jrwrigh commented 1 year ago

Alright, updates pushed up now.

sainnhe / sonokai

Update highlight links for neovim lsp semantic tokens #86