sainnhe / sonokai

High Contrast & Vivid Color Scheme based on Monokai Pro
MIT License
1.65k stars 119 forks source link

Support Neo-tree.nvim #88

Closed kaykhan closed 1 year ago

kaykhan commented 1 year ago

I see sonokai has support for nvim-tree. Ive recently migrated from nvim-tree to neo-tree.

Would it be possible to add support for this? https://github.com/nvim-neo-tree/neo-tree.nvim

In the meantime ive been using this - https://github.com/nvim-neo-tree/neo-tree.nvim/wiki/Visual-Customizations#colour-scheme

antoineco commented 1 year ago

It looks simple enough 👍 We would do exactly the same as they suggest: link both groups.

antoineco commented 1 year ago

I just noticed that we already have a few highlight groups for Neo-tree since b2199f489f94ae55dbabffd707e7be0338595965, so if they don't work, it means that they are probably outdated:

https://github.com/sainnhe/sonokai/blob/c995ad5d01712fdd9c7e9529edb035bd5a2c0b0b/colors/sonokai.vim#L1446-L1466

Ref.

kaykhan commented 1 year ago

Interesting i just know that the color of the folder icon did not match what i had in nvim-tree. https://github.com/nvim-neo-tree/neo-tree.nvim/blob/v2.x/doc/neo-tree.txt#L1154

antoineco commented 1 year ago

That is very likely. We did not link this highlight group explicitly, so if both Neo-tree and nvim-tree pick different values, they will look different in both plugins.

Any other difference you think we should address?

kaykhan commented 1 year ago

That is very likely. We did not link this highlight group explicitly, so if both Neo-tree and nvim-tree pick different values, they will look different in both plugins.

Any other difference you think we should address?

Not that i can think of