search

saintdev / speedrun-api

Rust API for speedrun.com
3 stars 2 forks source link

Derive Eq and Hash #2

Closed FoxLisk closed 2 years ago

FoxLisk commented 2 years ago

I only derived this on CategoryId here, because that's where I actually needed it, but I am happy to go through and add these for every ThingId if you agree it's a good idea.

See here for justification: https://rust-lang.github.io/api-guidelines/interoperability.html#c-common-traits

saintdev commented 2 years ago

I only derived this on CategoryId here, because that's where I actually needed it, but I am happy to go through and add these for every ThingId if you agree it's a good idea.

That sounds great! I think I intended to do that at one point and forgot.

FoxLisk commented 2 years ago

I think this is all of them!

saintdev commented 2 years ago

Merged, thanks!