search

saintfish / chardet

Charset detector library for golang derived from ICU
Other
345 stars 62 forks source link

This seems to be a bug?? #6

Open lysShub opened 3 years ago

lysShub commented 3 years ago

I try to read the source code。

func newRecognizer_8859_2(language string, ngram *[64]uint32) *recognizerSingleByte {
    return &recognizerSingleByte{
        charset:          "ISO-8859-2",
        hasC1ByteCharset: "windows-1250",
        language:         language,
        charMap:          &charMap_8859_2,
        ngram:            ngram,
    }
}

func newRecognizer_8859_2_cs() *recognizerSingleByte {
    return newRecognizer_8859_1("cs", &ngrams_8859_2_cs)
}
func newRecognizer_8859_2_hu() *recognizerSingleByte {
    return newRecognizer_8859_1("hu", &ngrams_8859_2_hu)
}
func newRecognizer_8859_2_pl() *recognizerSingleByte {
    return newRecognizer_8859_1("pl", &ngrams_8859_2_pl)
}
func newRecognizer_8859_2_ro() *recognizerSingleByte {
    return newRecognizer_8859_1("ro", &ngrams_8859_2_ro)
}

https://github.com/saintfish/chardet/blob/master/single_byte.go 315 According to the function naming rule，maybe

func newRecognizer_8859_2_cs() *recognizerSingleByte {
    return newRecognizer_8859_2("cs", &ngrams_8859_2_cs)
}
agclqq commented 2 years ago

You're very careful. I think you're right