search

sainthkh / reasonql

Type-safe and simple GraphQL library for ReasonML developers.
MIT License
96 stars 5 forks source link

Finished promise #10

Closed c19 closed 5 years ago

c19 commented 5 years ago

finished function return a promise instead of using a callback.

sainthkh commented 5 years ago

This PR would break current API, wouldn't it?

c19 commented 5 years ago

This PR would break current API, wouldn't it?

Yes, we could add another API to satisfy different style of async code and keep backward compatible. I'll leave that for you decide.

sainthkh commented 5 years ago

To make current API valid, how about renaming suggested promise versions to finishedP and finishedWithErrorP and not making changes to current finished functions?

c19 commented 5 years ago

updated.