saintsystems / odata-client-php

OData Client Library for PHP
MIT License
141 stars 103 forks source link

Fix interfaces and add missing IODataResponse #127

Open Involture opened 1 year ago

Involture commented 1 year ago

Intends to Fix #83

I am not sure about the point of the interfaces. phpDoc comments were clearly wrong about the return type of some functions. I replaced IODataRequest with a new interface IODataResponse

If this is not what was envisioned, Im happy to modify the PR and help correct doc blocks and interfaces

anderly commented 1 year ago

@Involture this looks good. I think we just need to change ODataResponse by adding implements IODataResponse.

Can you add that and I'll merge?