search

saintsystems / odata-client-php

OData Client Library for PHP
MIT License
141 stars 103 forks source link

Compatibility with PHP 7.4 #134

Closed esurov closed 1 year ago

esurov commented 1 year ago

UPDATE: Please check the PR that fixes this issue: https://github.com/saintsystems/odata-client-php/pull/135

The package states to support PHP 7.4 in the composer.json and also in the .travis.ci (the builds don't run though)

vendor/bin/phpunit -c phpunit.xml
PHPUnit 9.6.9 by Sebastian Bergmann and contributors.

..PHP Fatal error:  Declaration of SaintSystems\OData\Entity::offsetExists(SaintSystems\OData\mixed $offset): bool must be compatible with ArrayAccess::offsetExists($offset) in /var/development/odata-client-php/src/Entity.php on line 820
n8rowley commented 1 year ago

If we could get this fixed, that would be great.

Does anyone know the latest version of this package that is still compatible with PHP7.4?

gRegorLove commented 1 year ago

@n8rowley Looks like it's the previous version, 0.6.2. That's working for me at first glance under PHP7.4

It looks like the Travis CI builds haven't been running for a while. I'll open a separate issue about that so ideally the build process will catch these types of issues.

anderly commented 1 year ago

Should be fixed now. Github Actions build added with matrix of PHP 7.3, 7.4, 8.0, 8.1 and 8.2.

anderly commented 1 year ago

This is available in Release 0.6.4

n8rowley commented 1 year ago

Looks like we missed one instance. See #139

anderly commented 1 year ago

@n8rowley, this is fixed in Release 0.6.5