saintzaw / pe

0 stars 0 forks source link

Inconsistency in handling whitespaces in input #7

Open saintzaw opened 1 year ago

saintzaw commented 1 year ago

Untitled11.png

Whitespaces were allowed and subsequently handled/removed when used in the owner name and contact number fields in the edit command but when I used a whitespace before the uid in the mark command I was told it is invalid. This inconsistency causes inconvenience for users.

nus-se-bot commented 1 year ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

During the original implementation, we plan to allow for more leeway in the edit and add features as the users are understandably keying in pretty long inputs at one go, hence there might be accidental leading whitespaces which we will trim. Our original intention for mark not having this flexibility was because it was a short command (bar the UID itself), hence we do not expect leading whitespaces. In addition, the warning message is thrown with the proper format being reminded. However, we might consider implementing the same flexibility for the other features in the future.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your reason]