search

sairum / tcsBU

a TCS network beautifier
MIT License
7 stars 4 forks source link

Issue with colors of legend #1

Closed josephhughes closed 8 years ago

josephhughes commented 8 years ago

Hi @sairum,

Really neat tool, it is very useful but I am having issues with the colors in the legend which do not correspond to the colors I have assigned. I've attached a screenshot and the input files.

I'd be really grateful if you could help. Thanks, Joseph

screen shot 2015-11-19 at 14 29 43

CalssificationGroups.txt HaplotypeGroups.txt TCS_network.txt

sairum commented 8 years ago

Hi

A very strange bug! I still have to know what causes it. The thing is that in your "CalssificationGroups.txt" you have

L1420;#B2DF8A L2761;#FFD92F L1420;#E7298A L6273;#FDC086 L6652;#BF5B17 L9476;#7FC97F L6292;#FC8D62 L1680;#E5D8BD L6285;#BEBADA L2220;#E41A1C L9814;#80B1D3 L6285;#377EB8 L9631;#FCCDE5 L1353;#D9D9D9

Note that L1420 is repeated with two different colors (lines 1 and 3). If you remove the first everything works as expected, I presume. But the fact is that the interface should spot these mistakes when loading data and it didn't! NOTE: The software was published in Bioinformatics (see early view for citation, please!)

Regards

Antonio

On 11/19/2015 04:21 PM, Joseph Hughes wrote:

Hi @sairum https://github.com/sairum,

Really neat tool, it is very useful but I am having issues with the colors in the legend which do not correspond to the colors I have assigned. I've attached a screenshot and the input files.

I'd be really grateful if you could help. Thanks, Joseph screen shot 2015-11-19 at 14 29 43 https://cloud.githubusercontent.com/assets/359553/11276276/61284afa-8ed9-11e5-8ce0-d448efd6e3bf.png CalssificationGroups.txt https://github.com/sairum/tcsBU/files/39162/CalssificationGroups.txt HaplotypeGroups.txt https://github.com/sairum/tcsBU/files/39161/HaplotypeGroups.txt TCS_network.txt https://github.com/sairum/tcsBU/files/39166/TCS_network.txt

— Reply to this email directly or view it on GitHub https://github.com/sairum/tcsBU/issues/1.

sairum commented 8 years ago

I've committed a fix to ignore repeated names in the Groups's classification file. Please try it with your original data (with the repeated group L1420) just to see if it works. Note that I still have to push these changes to the online version of tcsBU, but I currently I do not have access to it (it may take some days)

josephhughes commented 8 years ago

Hi @sairum,

Thanks for your prompt response. I have removed the duplicate Groups but I am still getting something odd happening for the legend. The attached screenshot shows that L1353 and L9631 re the wrong colors. Let me know when you've managed to push the changes.

Cheers, Joseph

screen shot 2015-11-20 at 10 41 45
sairum commented 8 years ago

Apparently my fix did not solve the problem... You have another duplicated value in the Groups file (L6258). Removing it solves the problem for now. This means that I still have to come up with a proper algorithm to avoid duplicated group labels while loading group files!

EDIT: I've checked the algorithm and it is behaving as expected. Did you refresh the cache of your browser? Are you using the online version of the software. If the latter is true, I will only be able to update the online software with the fixed version (on master) next Monday... in this case, removing duplicate values will fix the problem

josephhughes commented 8 years ago

Hi @sairum,

It works fine now. Thanks for your help.

Joseph