soc-pe-bot
commented
5 months ago [IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]
Team's Response
No details provided by team.
The 'Original' Bug
[The team marked this bug as a duplicate of the following bug]
Duplicate task checking is not case-sensitive
As mentioned in the title, the checking for duplicate tasks is not case-sensitive. This may result in actual duplicate tasks when it is actually just a difference in case sensitivity.
To reproduce:
- addtask n/task1 d/something p/1 by/18-02-2022 12:00
- addtask n/Task1 d/something p/1 by/18-02-2022 12:00
I suggest that the duplicate check for task names be made case-sensitive and/or be extended to the deadline of the task as well (a task is duplicate if and only if the name and the deadline of both tasks are equal)
[original: nus-cs2103-AY2324S2/pe-interim#407] [original labels: type.FunctionalityBug severity.Medium]
Their Response to the 'Original' Bug
[This is the team's response to the above 'original' bug]
We intended for two tasks to be considered different if the casing for the task names is different. The fact that both commands succeed is intended, therefore this is certainly not a functionality bug.
We claim that this is also not a feature flaw, because the meaning of a task might change simply by changing the casing in the task name. For example, "Write email to teammates" and "Write email to TEAMMATES" are different tasks. The latter likely refers to the task of sending an email to the TEAMMATES dev team.
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
- [ ] I disagree
Reason for disagreement: [replace this with your reason]
## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
Context
2 tasks are allowed to be added, with the same name
Screenshots
Expected Behaviour vs Actual Behaviour
2 tasks shouldnt be the same name. If the tasks are different, they have to be different in some way, and hence their names can be changes to provide more specificty
Also, as can been seen by the second screenshot - unsure of which Task 1 Alex is assigned to, as there are multiple with the same name.
How to replicate
addtask n/Task 1 d/Do homework p/HIGH addtask n/Task 1 d/Do homework p/LOW
Why this severity:
Was trying to figure this out between medium and low, but realised that it is rare for 2 tasks to have the same name, but I though it would be good because then it forces the user to add more specifics.