search

saiwong / ember-handlebars-brunch

Ember Handlebars integration for Brunch
MIT License
2 stars 13 forks source link

remove old include #1

Closed icholy closed 12 years ago

icholy commented 12 years ago

this way users are free to place ember where they want and use a newer version.

saiwong commented 12 years ago

The include is needed to compile the template via the Ember Handlebars framework. The framework is not actually included in the output, only the output of the compiled template. I think the better route is the do a dependency include under package.json to link in the latest version of ember and use that instead.

icholy commented 12 years ago

if someone is using this plugin, I think they're smart enough to know they need Ember for it to work.

icholy commented 12 years ago

if you were actually pre-compiling the templates, then you would need it. But it's in no way used during the build process.

saiwong commented 12 years ago

Yeah, so I feel that removing the include makes sense, but I rather just update the code to do the actual precompile.

icholy commented 12 years ago

I was thinking the same thing. I've already started working on getting pre-compiling working with the latest version of ember.

icholy commented 12 years ago

latest version being the master branch, not 9.8.1

icholy commented 12 years ago

I'll re-open when it's ready