sajalverma17 / GitBranchDiffer

A Visual Studio Extension that displays source files Added/Modified/Renamed between a base branch you choose to diff against, and the current working branch in your Git repo. The diffed files are shown in the Solution Explorer using a Solution Explorer Filter
MIT License
6 stars 1 forks source link

When the GitBranchDiffer filter is un-applied, diff windows are still left open #7

Open sajalverma17 opened 3 years ago

sajalverma17 commented 3 years ago

Version Information :

Describe the bug The bug is related to opening a file from Solution Explorer after the "Show diff in solution" filter was successfully applied on. When the filter is un-applied, and I jump to a class from another class, Visual Studio opens that document's Diff Window instead of normal view.

This is because the class was previously opened under the GitBranchDiffer filter, which created a Diff Window of it, and after the filter was un-applied, the window is still left open and VS identifies it as the primary window for that class.

Expected behavior Once the filter is Un-applied, user should not see the diff window of comparison of current with base branch.

Additional context This bug DOES NOT exist due to the "Track Active Item In Solution Explorer" being switched on. Jumping to another item leads to change in selection of item in Solution Explorer, but since Git Branch Diff filter is Un-Applied, we do not open a comparison window from out extension.

A possible fix is to close all comparison window when filter is Un-Applied?