search

sajari / storage

Go package for abstracting local, in-memory, and remote (Google Cloud Storage/S3) filesystems
MIT License
52 stars 11 forks source link

Resource not closed #2

Closed ash2k closed 8 years ago

ash2k commented 8 years ago

Hey, I was skimming through the sources and noticed that https://github.com/sajari/storage/blob/master/hash.go#L79 will return early without calling Close if copy fails. Just wanted to let you know.

p.s. thanks for the interesting talk yesterday at Golang Syd!

dhowden commented 8 years ago

Good spot - thanks for the report!

I have a lot of updates coming which will bring this package more in line with what I was talking about, so watch this space!