sajingeo / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Add Code Review for Other VCS #122

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Please provide any additional information below.
upload.py understands diffs for mercurial, but "Add Repository" and "Create
Issue" actions are both work only with SVN repositories.

Original issue reported on code.google.com by techtonik@gmail.com on 9 Jun 2009 at 11:04

GoogleCodeExporter commented 9 years ago
This is houw it's supposed to work.  The repository is only needed by the create
issue form, and we're deprecating the create issue form in favor of using 
upload.py
for all use cases.  So we're not definitely adding new features to the form or 
the
Repositories tab.

Original comment by gvanrossum@gmail.com on 9 Jun 2009 at 2:55

GoogleCodeExporter commented 9 years ago
It would be nice to make this clear on issue creation page and add some 
examples to
http://code.google.com/p/rietveld/wiki/UploadPyUsage

Original comment by techtonik@gmail.com on 9 Jun 2009 at 4:36

GoogleCodeExporter commented 9 years ago
There's already an intermediate page when using the issue creation form. A link 
to
the mentioned Wiki page is already included
too:http://codereview.appspot.com/use_uploadpy

You have to explicitly disable this page to go straight to the create issue 
page.

Original comment by albrecht.andi on 9 Jun 2009 at 6:07

GoogleCodeExporter commented 9 years ago
I've seen this page, but it sounds like update.py is less advanced than Create 
Issue
interface, so I expected it to be true.

Original comment by techtonik@gmail.com on 9 Jun 2009 at 7:51