sajingeo / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

MercurialVCS fails to upload base files when --rev is set #127

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Try to upload a changeset from a hg repository with --rev option, for 
example "upload.py --rev 318:319" to upload changes introduced in revision 
319.
2.
3.

What is the expected output? What do you see instead?

upload.py should upload the changes, instead it fails with "Got error 
status from ['hg', 'cat', '-r', '316:317', 'codereview/engine.py']"

The problem is that the revision option isn't handled correctly when 
uploading base files. The "-r" option when calling "hg cat" shouldn't be 
the revision range, but the base revision, 316 in that case.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by albrecht.andi on 28 Jun 2009 at 7:18

GoogleCodeExporter commented 9 years ago
Patch uploaded to codereview: http://codereview.appspot.com/89055

Original comment by albrecht.andi on 28 Jun 2009 at 7:35

GoogleCodeExporter commented 9 years ago
Fixed in r426.

Original comment by albrecht.andi on 30 Jun 2009 at 6:02