search

sajingeo / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Make it clearer which file I'mm currently reviewing #148

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
From http://code.google.com/p/chromium/issues/detail?id=20512

I always find it hard to find which file I'm in and which file comments apply 
to.

There are 2 problems here.

1. The document.title currently have the whole path so the filename usually 
gets cut 
off. For example my tab shows 'chrome/browser/history/...'. It would be better 
if it 
said 'download_types.h - chrome/browse...'

2. The URL to the page I'm currently viewing is something like 
http://codereview.chromium.org/178001/diff/4064/3058#newcode568. It would be 
nice if 
the URL contained the filename in it as well. (Mondrian has this and I'm used 
to 
glancing at the address bar for this information).

-------------------------------------------------

I've run in those same issue as well and find it annoying.  Even setting the 
correct 
title might not be that useful in Chrome which doesn't have a title bar.  The 
small 
tab space isn't enough to show the path.

We can put it in the url, but then have to deal with spaces and other 
characters 
(which would make copy & pasting it from there not possible), or maybe have a 
floating div that displays information about the current file.

Original issue reported on code.google.com by erik.arv...@gmail.com on 28 Aug 2009 at 9:23

GoogleCodeExporter commented 9 years ago 
This problem seems to be specific to the chromium codereview site. The main 
Rietveld
site puts the last segment of the filename, see e.g.
http://codereview.appspot.com/109094/diff/8/1001

Original comment by gvanrossum@gmail.com on 29 Aug 2009 at 12:20