sajingeo / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Emails send with patches should be with user's "Column Width" preference #150

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Emails received with patches have a column width of 62.
It should be better to use the "Column Width" preference.

Original issue reported on code.google.com by cedric.krier@b2ck.com on 1 Sep 2009 at 3:04

GoogleCodeExporter commented 9 years ago
I'm not sure I agree. The column width in email is used to overcome very 
different
space constraints than the column width in the diff viewer. I may be reviewing 
code
with long lines so that I have to set the column width to 150 -- but that 
doesn't
mean I want to receive the comments in the email formatted at that width!

(Also make sure that what you're seeing is the formatting sent out by Rietveld 
--
some email readers may also break long lines, and there's nothing we can do 
about that.)

Original comment by gvanrossum@gmail.com on 1 Sep 2009 at 5:04

GoogleCodeExporter commented 9 years ago
So it could be only for the diff part of the email or all the email with width 
of 80
instead of 62.

(I use mutt which I'm pretty sure doesn't change the layout of the email)

Original comment by cedric.krier@b2ck.com on 1 Sep 2009 at 5:19

GoogleCodeExporter commented 9 years ago
I think this is a wontfix. The mail is sent to multiple recipients (issue 
owner, 
reviewers and CCs) so there's most likely no common column_width.
When an issue is created the patch (if included at all) isn't wrapped. Only 
when a long 
line is shown above a comment it's wrapped to 72 chars, but that isn't a 
problem IMO as 
it just the context of a comment but not the patch itself.

Original comment by albrecht.andi on 1 Sep 2009 at 5:47

GoogleCodeExporter commented 9 years ago

Original comment by gvanrossum@gmail.com on 1 Sep 2009 at 6:16